Bug 56943

Summary: CSS3 nth-child(n) selector fails
Product: WebKit Reporter: Ian Ellison-Taylor <ianet>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, lea, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://tools.css3.info/selectors-test/test.html
Attachments:
Description Flags
nth-child(n) test case
none
Simpler test case
none
Patch. none

Description Ian Ellison-Taylor 2011-03-23 11:41:04 PDT
Created attachment 86654 [details]
nth-child(n) test case

The nth-child(n) CSS3 test fails although nth-child(1n) passes.

See the attached test, the background for the 4 elements should be red.
Comment 1 Ian Ellison-Taylor 2011-03-23 11:49:42 PDT
Created attachment 86658 [details]
Simpler test case

Added a simpler test from Tab, text in the test should be green
Comment 2 Lea Verou 2011-04-02 07:46:15 PDT
FWIW, here's another testcase: http://jsfiddle.net/leaverou/Cum32/
Comment 3 Yael 2011-04-30 21:03:05 PDT
Created attachment 91811 [details]
Patch.
Comment 4 Eric Seidel (no email) 2011-05-01 09:44:55 PDT
Comment on attachment 91811 [details]
Patch.

OK.
Comment 5 Eric Seidel (no email) 2011-05-01 09:45:30 PDT
The spec link in the ChangeLog or source would have been nice. :)

Also generally our test cases use 4-space indent (like the rest of our code), but it's not a big deal.
Comment 6 WebKit Commit Bot 2011-05-01 10:08:37 PDT
Comment on attachment 91811 [details]
Patch.

Clearing flags on attachment: 91811

Committed r85416: <http://trac.webkit.org/changeset/85416>
Comment 7 WebKit Commit Bot 2011-05-01 10:08:43 PDT
All reviewed patches have been landed.  Closing bug.