Bug 56938

Summary:

Unexpected behaviour in spatial navigation with overlapping nodes

Product:

WebKit

Reporter:

Michaël Burtin <mburtin>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

buildbot, cfleizach, cshu, kandalkar.abhijeet58, kevin.cs.oh, mario.bensi, rniwa, ssseintr2, tonikitoo, yael

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

119468

Bug Blocks:

46905

Attachments:

Description	Flags
reduced test case of spatial navigation behavior with overlapping nodes	none
Overlapping node test	none
Updated patch-1	cfleizach: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none

Michaël Burtin

Reported 2011-03-23 10:46:28 PDT

Created attachment 86644 [details] reduced test case of spatial navigation behavior with overlapping nodes Spatial navigation behavior when two nodes are intersecting might be improved. With the actual code that looks for a focus candidate, if a new candidate is intersecting the current one, the topmost element is retained. This can lead to unexpected behavior when multiple elements are overlapping with a small intersecting area. You can find in attachment a reduced test case. If you hit down arrow, focus will go to the last element. IMO, when nodes are intersecting, the algorithm should consider the intersecting area and respective node distances when choosing candidate. I'll try to make a patch for this, but it may require more knowledge than I have on spatial navigation requirements.

Attachments
reduced test case of spatial navigation behavior with overlapping nodes (719 bytes, text/html) 2011-03-23 10:46 PDT, Michaël Burtin	no flags	Details
Overlapping node test (2.32 KB, text/html) 2013-05-26 07:46 PDT, Abhijeet Kandalkar	no flags	Details
Updated patch-1 (3.90 KB, patch) 2013-08-04 05:00 PDT, Abhijeet Kandalkar	cfleizach: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (518.59 KB, application/zip) 2013-08-04 10:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (500.12 KB, application/zip) 2013-08-04 11:06 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Abhijeet Kandalkar

Comment 1 2013-05-25 13:37:08 PDT

I have patch,will update soon.

Abhijeet Kandalkar

Comment 2 2013-05-26 07:46:47 PDT

Created attachment 202921 [details] Overlapping node test Following scenario also should work .

Abhijeet Kandalkar

Comment 3 2013-08-04 05:00:16 PDT

Created attachment 208087 [details] Updated patch-1 Patch for bug https://bugs.webkit.org/show_bug.cgi?id=119468 fixes this bug also. Attached patch is a separate layout-test to test the behavior mentioned in this bug.

Build Bot

Comment 4 2013-08-04 10:05:52 PDT

Comment on attachment 208087 [details] Updated patch-1 Attachment 208087 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1333807 New failing tests: fast/spatial-navigation/snav-overlapping-nodes.html

Build Bot

Comment 5 2013-08-04 10:05:55 PDT

Created attachment 208094 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Build Bot

Comment 6 2013-08-04 11:05:59 PDT

Comment on attachment 208087 [details] Updated patch-1 Attachment 208087 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1339862 New failing tests: fast/spatial-navigation/snav-overlapping-nodes.html

Build Bot

Comment 7 2013-08-04 11:06:02 PDT

Created attachment 208096 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Antonio Gomes

Comment 8 2013-08-16 07:26:51 PDT

(In reply to comment #3) > Created an attachment (id=208087) [details] > Updated patch-1 > > Patch for bug https://bugs.webkit.org/show_bug.cgi?id=119468 fixes this bug also. > > Attached patch is a separate layout-test to test the behavior mentioned in this bug. Please incorporate this test to your patch, referencing the original Author in the ChangeLog.

Build Bot

Comment 9 2013-08-26 18:34:04 PDT

Comment on attachment 208087 [details] Updated patch-1 Attachment 208087 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1592079

chris fleizach

Comment 10 2013-12-20 22:12:48 PST

r- for failing tests and no ChangeLog

Note You need to log in before you can comment on or make changes to this bug.