Bug 56923

Summary: Regression: WebKit does not build with Python 3 following 56807
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: benjamin, commit-queue, eric
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 56807    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-03-23 07:23:43 PDT
The following broke the build because string.replace has been removed from Python 3. diff --git a/Source/WebCore/inspector/generate-inspector-idl b/Source/WebCore/inspector/generate-inspector-idl index 5712f40..c4b9c1b 100755 --- a/Source/WebCore/inspector/generate-inspector-idl +++ b/Source/WebCore/inspector/generate-inspector-idl @@ -41,6 +41,8 @@ input_path = sys.argv[3] input_file = open(input_path, "r") json_string = input_file.read() +json_string = string.replace(json_string, ": true", ": True") +json_string = string.replace(json_string, ": false", ": false") json_api = eval(json_string) output_file = open(output_path, "w")
Attachments
Patch (1.55 KB, patch)
2011-03-23 07:32 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-03-23 07:32:24 PDT
Created attachment 86615 [details] Patch
Andreas Kling
Comment 2 2011-03-24 05:04:29 PDT
Comment on attachment 86615 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2011-03-24 06:45:09 PDT
The commit-queue encountered the following flaky tests while processing attachment 86615 [details]: http/tests/websocket/tests/workers/close-in-onmessage-crash.html bug 57011 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-03-24 06:48:36 PDT
Comment on attachment 86615 [details] Patch Clearing flags on attachment: 86615 Committed r81863: <http://trac.webkit.org/changeset/81863>
WebKit Commit Bot
Comment 5 2011-03-24 06:48:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2011-03-24 07:15:03 PDT
The commit-queue encountered the following flaky tests while processing attachment 86615 [details]: java/lc3/JavaObject/JavaObjectToLong-004-n.html bug 57012 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.