Bug 56923 - Regression: WebKit does not build with Python 3 following 56807
Summary: Regression: WebKit does not build with Python 3 following 56807
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Enhancement
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 56807
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-23 07:23 PDT by Benjamin Poulain
Modified: 2011-03-24 07:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2011-03-23 07:32 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-03-23 07:23:43 PDT 
The following broke the build because string.replace has been removed from Python 3.

diff --git a/Source/WebCore/inspector/generate-inspector-idl b/Source/WebCore/inspector/generate-inspector-idl
index 5712f40..c4b9c1b 100755
--- a/Source/WebCore/inspector/generate-inspector-idl
+++ b/Source/WebCore/inspector/generate-inspector-idl
@@ -41,6 +41,8 @@ input_path = sys.argv[3]
 
 input_file = open(input_path, "r")
 json_string = input_file.read()
+json_string = string.replace(json_string, ": true", ": True")
+json_string = string.replace(json_string, ": false", ": false")
 json_api = eval(json_string)
 
 output_file = open(output_path, "w")
Comment 1 Benjamin Poulain 2011-03-23 07:32:24 PDT 
Created attachment 86615 [details]
Patch
Comment 2 Andreas Kling 2011-03-24 05:04:29 PDT 
Comment on attachment 86615 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2011-03-24 06:45:09 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86615 [details]:

http/tests/websocket/tests/workers/close-in-onmessage-crash.html bug 57011 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-03-24 06:48:36 PDT 
Comment on attachment 86615 [details]
Patch

Clearing flags on attachment: 86615

Committed r81863: <http://trac.webkit.org/changeset/81863>
Comment 5 WebKit Commit Bot 2011-03-24 06:48:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2011-03-24 07:15:03 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86615 [details]:

java/lc3/JavaObject/JavaObjectToLong-004-n.html bug 57012 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.