Bug 56882

Summary: Add API to retrieve the audio hardware sample-rate
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+

Chris Rogers
Reported 2011-03-22 16:59:58 PDT
Add API to retrieve the audio hardware sample-rate
Attachments
Patch (2.35 KB, patch)
2011-03-22 17:02 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-03-22 17:02:11 PDT
Created attachment 86546 [details] Patch
Kenneth Russell
Comment 2 2011-03-22 17:07:34 PDT
Comment on attachment 86546 [details] Patch Looks fine to me; do you want to commit the Chromium side first?
Chris Rogers
Comment 3 2011-03-22 17:09:22 PDT
Thanks, Ken, yes I will have to. Here's that CL: http://codereview.chromium.org/6721015/
Chris Rogers
Comment 4 2011-03-23 13:04:50 PDT
Committed r81797: <http://trac.webkit.org/changeset/81797>
Tony Chang
Comment 5 2011-03-23 14:21:00 PDT
I'm getting a compilation error in Chromium with this change: content/renderer/renderer_webkitclient_impl.cc: In member function ‘virtual WebKit::WebAudioDevice* RendererWebKitClientImpl::createAudioDevice(size_t, unsigned int, double, WebKit::WebAudioDevice::RenderCallback*)’: content/renderer/renderer_webkitclient_impl.cc:553: error: cannot allocate an object of abstract type ‘RendererWebAudioDeviceImpl’ ./content/renderer/renderer_webaudiodevice_impl.h:16: note: because the following virtual functions are pure within ‘RendererWebAudioDeviceImpl’: ./third_party/WebKit/Source/WebKit/chromium/public/WebAudioDevice.h:51: note: virtual double WebKit::WebAudioDevice::sampleRate() It looks like renderer_webaudiodevice_impl.* needs to declare sampleRate()?
Chris Rogers
Comment 6 2011-03-23 14:28:31 PDT
Tony, sorry about that. I'll land a temporary fix on the chromium-side...
Chris Rogers
Comment 7 2011-03-23 14:38:38 PDT
I have a patch about ready to land: http://codereview.chromium.org/6733006/
Note You need to log in before you can comment on or make changes to this bug.