Bug 56876

Summary: WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56425    
Attachments:
Description Flags
Patch v1 sam: review+, beidson: commit-queue-

Brady Eidson
Reported 2011-03-22 16:03:36 PDT
WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread This is blocking https://bugs.webkit.org/show_bug.cgi?id=56425 IconDatabase for WebKit2.
Attachments
Patch v1 (18.57 KB, patch)
2011-03-22 16:15 PDT, Brady Eidson 		sam: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2011-03-22 16:06:40 PDT
The expansion of the client interface is inspired by Patch #3 in https://bugs.webkit.org/show_bug.cgi?id=56425 and is laying the groundwork for future use.
Brady Eidson
Comment 2 2011-03-22 16:15:45 PDT
Created attachment 86533 [details] Patch v1
WebKit Review Bot
Comment 3 2011-03-22 16:18:54 PDT
Attachment 86533 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/icon/IconDatabase.cpp:88: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/loader/icon/IconDatabase.cpp:2123: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/loader/icon/IconDatabase.cpp:2147: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/loader/icon/IconDatabase.cpp:2171: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2011-03-22 16:25:41 PDT
(In reply to comment #3) > Attachment 86533 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebCore/loader/icon/IconDatabase.cpp:88: This { should be at the end of the previous line [whitespace/braces] [4] > Source/WebCore/loader/icon/IconDatabase.cpp:2123: This { should be at the end of the previous line [whitespace/braces] [4] > Source/WebCore/loader/icon/IconDatabase.cpp:2147: This { should be at the end of the previous line [whitespace/braces] [4] > Source/WebCore/loader/icon/IconDatabase.cpp:2171: This { should be at the end of the previous line [whitespace/braces] [4] > Total errors found: 4 in 10 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. All style errors fixed locally for the landing, once I get a review.
Sam Weinig
Comment 5 2011-03-22 16:28:12 PDT
Comment on attachment 86533 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=86533&action=review >> Source/WebCore/loader/icon/IconDatabase.cpp:88 >> +{ > > This { should be at the end of the previous line [whitespace/braces] [4] I agree with the mighty style bot.
Brady Eidson
Comment 6 2011-03-22 16:30:04 PDT
r81719
Note You need to log in before you can comment on or make changes to this bug.