Bug 56857

Summary: [chromium] Make WebTextCheckingResult's members be public in preparation for converting it to a struct
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: New BugsAssignee: John Abd-El-Malek <jam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

John Abd-El-Malek
Reported 2011-03-22 12:44:08 PDT
[chromium] Make WebTextCheckingResult's members be public in preparation for converting it to a struct
Attachments
Patch (1.68 KB, patch)
2011-03-22 12:44 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Patch (3.47 KB, patch)
2011-03-22 14:55 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Patch (3.47 KB, patch)
2011-03-22 16:08 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2011-03-22 12:44:26 PDT
Created attachment 86494 [details] Patch
WebKit Review Bot
Comment 2 2011-03-22 13:07:33 PDT
Attachment 86494 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8218955
John Abd-El-Malek
Comment 3 2011-03-22 14:55:19 PDT
Created attachment 86513 [details] Patch
John Abd-El-Malek
Comment 4 2011-03-22 14:56:00 PDT
updated patch per discussion so that "m_" is removed from the variable names.
Tony Chang
Comment 5 2011-03-22 15:06:27 PDT
Comment on attachment 86513 [details] Patch The change is fine, but looks like we can't roll chromium deps because ui_unittests.gypi is trying to pull in chrome.gyp. Let me see if I can fix that dependency first.
WebKit Review Bot
Comment 6 2011-03-22 15:39:40 PDT
Attachment 86513 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8222500
John Abd-El-Malek
Comment 7 2011-03-22 16:08:58 PDT
Created attachment 86531 [details] Patch
John Abd-El-Malek
Comment 8 2011-03-22 17:25:06 PDT
Committed r81729: <http://trac.webkit.org/changeset/81729>
Hajime Morrita
Comment 9 2011-03-22 18:52:13 PDT
Should this be a struct? It looks there is some convention that I miss...
Ryosuke Niwa
Comment 10 2011-04-03 04:09:30 PDT
Comment on attachment 86531 [details] Patch Clearing r+ of the landed patch.
Note You need to log in before you can comment on or make changes to this bug.