Bug 56847

Summary:

WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	aroben: review+

Description Sam Weinig 2011-03-22 11:17:45 PDT

WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)

Comment 1 Sam Weinig 2011-03-22 11:19:19 PDT

Created attachment 86482 [details]
Patch

Comment 2 Adam Roben (:aroben) 2011-03-22 11:24:44 PDT

Comment on attachment 86482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86482&action=review

> Source/WebKit2/Shared/mac/WebEventFactory.mm:45
> +    if (!pressedMouseButtons)
> +        return WebMouseEvent::NoButton;
> +    if (pressedMouseButtons == 1 << 0)
> +        return WebMouseEvent::LeftButton;
> +    if (pressedMouseButtons == 1 << 1)
> +        return WebMouseEvent::RightButton;

Surprising that there aren't constants for these!

Comment 3 Adele Peterson 2011-04-06 17:53:07 PDT

Fixed in r81679.