Bug 56843

Summary:

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+
Remove debuggerScriptSource implementation from DRT.	none
Remove references to DebuggerScript.js from DRT and Qt port.	pfeldman: review+
Remove DebuggerScript.js from Chromium resource bundle.	pfeldman: review-

Yury Semikhatsky

Reported 2011-03-22 10:44:58 PDT

Now DebuggerScript.js is provided to v8/ScriptDebugServer by WebKit layer. The script itself is a part of WebCore and it would be nice to avoid this round-trip. We already do the same thing with InjectedScriptSource.js

Attachments
Patch (8.98 KB, patch) 2011-03-22 10:55 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (13.15 KB, patch) 2011-03-22 23:31 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
Remove debuggerScriptSource implementation from DRT. (1.88 KB, patch) 2011-03-23 03:32 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Remove references to DebuggerScript.js from DRT and Qt port. (4.83 KB, patch) 2011-03-23 03:38 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
Remove DebuggerScript.js from Chromium resource bundle. (1.44 KB, patch) 2011-03-23 03:51 PDT, Yury Semikhatsky	pfeldman: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-03-22 10:55:34 PDT

Created attachment 86479 [details] Patch

WebKit Review Bot

Comment 2 2011-03-22 10:58:34 PDT

Attachment 86479 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/xxd.pl:44: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2011-03-22 11:03:19 PDT

Attachment 86479 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8218884

Early Warning System Bot

Comment 4 2011-03-22 11:10:39 PDT

Attachment 86479 [details] did not build on qt: Build output: http://queues.webkit.org/results/8228295

Pavel Feldman

Comment 5 2011-03-22 11:47:13 PDT

Comment on attachment 86479 [details] Patch This seems to break too many bots.

WebKit Review Bot

Comment 6 2011-03-22 13:22:26 PDT

Attachment 86479 [details] did not build on mac: Build output: http://queues.webkit.org/results/8222437

Yury Semikhatsky

Comment 7 2011-03-22 22:14:01 PDT

(In reply to comment #5) > (From update of attachment 86479 [details]) > This seems to break too many bots. For some reason InjectedScriptSource_js wasn't regenerated after xxd.pl changes.

Yury Semikhatsky

Comment 8 2011-03-22 23:31:06 PDT

Created attachment 86574 [details] Patch

Pavel Feldman

Comment 9 2011-03-23 02:48:32 PDT

Comment on attachment 86574 [details] Patch Use input and output aliases please.

Yury Semikhatsky

Comment 10 2011-03-23 03:10:05 PDT

Committed r81758: <http://trac.webkit.org/changeset/81758>

Yury Semikhatsky

Comment 11 2011-03-23 03:16:02 PDT

Some more cleanup should be done.

Yury Semikhatsky

Comment 12 2011-03-23 03:32:07 PDT

Created attachment 86595 [details] Remove debuggerScriptSource implementation from DRT.

Yury Semikhatsky

Comment 13 2011-03-23 03:38:12 PDT

Created attachment 86596 [details] Remove references to DebuggerScript.js from DRT and Qt port.

Yury Semikhatsky

Comment 14 2011-03-23 03:51:19 PDT

Created attachment 86598 [details] Remove DebuggerScript.js from Chromium resource bundle. This one should be landed once there are no references to the id from Chromium code.

WebKit Review Bot

Comment 15 2011-03-23 03:56:11 PDT

Attachment 86598 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8221875

Yury Semikhatsky

Comment 16 2011-03-23 04:10:07 PDT

Committed r81762

Pavel Feldman

Comment 17 2011-03-23 04:13:54 PDT

Comment on attachment 86598 [details] Remove DebuggerScript.js from Chromium resource bundle. Please do patch per bug. Or land things like this as not reviewed.

Yury Semikhatsky

Comment 18 2011-03-23 05:57:46 PDT

Will fix the rest in separate bugs. Closing this one.

Note You need to log in before you can comment on or make changes to this bug.