Bug 56841

Summary:

Web Inspector: add test for bug 56747 (scripts panel is broken when frontend is reopened).

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch.	pfeldman: review-
Patch.	pfeldman: review-
Patch.	pfeldman: review+

Pavel Podivilov

Reported 2011-03-22 10:25:58 PDT

Web Inspector: add test for bug 56747.

Attachments
Patch. (5.26 KB, patch) 2011-03-22 10:26 PDT, Pavel Podivilov	pfeldman: review-	Details Formatted Diff Diff
Patch. (6.18 KB, patch) 2011-03-23 03:15 PDT, Pavel Podivilov	pfeldman: review-	Details Formatted Diff Diff
Patch. (8.98 KB, patch) 2011-03-25 02:49 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-03-22 10:26:41 PDT

Created attachment 86472 [details] Patch.

Yury Semikhatsky

Comment 2 2011-03-22 11:02:45 PDT

Comment on attachment 86472 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review > LayoutTests/http/tests/inspector/inspector-test.js:262 > +var reopenFrontendTestCallId = 2; Can we make do without all these magical numbers? > LayoutTests/inspector/debugger/open-close-open.html:12 > + layoutTestController.showWebInspector(); I don't see the inspector close before it's shown again. Am I missing something? > LayoutTests/inspector/debugger/open-close-open.html:40 > +https://bugs.webkit.org/show_bug.cgi?id=56747 This link should be <a href=>

Pavel Feldman

Comment 3 2011-03-22 11:48:34 PDT

Pavel Podivilov

Comment 4 2011-03-23 03:15:52 PDT

Created attachment 86593 [details] Patch.

Pavel Podivilov

Comment 5 2011-03-24 02:38:06 PDT

(In reply to comment #2) > (From update of attachment 86472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86472&action=review > > > LayoutTests/http/tests/inspector/inspector-test.js:262 > > +var reopenFrontendTestCallId = 2; > > Can we make do without all these magical numbers? > > > LayoutTests/inspector/debugger/open-close-open.html:12 > > + layoutTestController.showWebInspector(); > > I don't see the inspector close before it's shown again. Am I missing something? > > > LayoutTests/inspector/debugger/open-close-open.html:40 > > +https://bugs.webkit.org/show_bug.cgi?id=56747 > > This link should be <a href=> Done.

Pavel Feldman

Comment 6 2011-03-24 11:23:45 PDT

Comment on attachment 86593 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=86593&action=review > LayoutTests/platform/mac-wk2/Skipped:2259 > +inspector/debugger/open-close-open.html How is this test different from the inspector-enabled/open-close-open? It will result in confusion when one of them fails.

Pavel Podivilov

Comment 7 2011-03-25 02:49:28 PDT

Created attachment 86912 [details] Patch.

Pavel Podivilov

Comment 8 2011-03-25 05:45:00 PDT

(In reply to comment #6) > (From update of attachment 86593 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86593&action=review > > > LayoutTests/platform/mac-wk2/Skipped:2259 > > +inspector/debugger/open-close-open.html > > How is this test different from the inspector-enabled/open-close-open? It will result in confusion when one of them fails. Removed the old test.

Pavel Podivilov

Comment 9 2011-03-30 06:54:25 PDT

Committed r82435: <http://trac.webkit.org/changeset/82435>

Note You need to log in before you can comment on or make changes to this bug.