Bug 56807

Summary: Web Inspector: document DOM domain types and protocol methods.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56923    
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Pavel Feldman
Reported 2011-03-22 00:45:14 PDT
Drive-by fixes for DOM agent methods included.
Attachments
Patch (33.33 KB, patch)
2011-03-22 00:56 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (33.95 KB, patch)
2011-03-22 02:11 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-03-22 00:56:09 PDT
Created attachment 86437 [details] Patch
WebKit Review Bot
Comment 2 2011-03-22 01:04:31 PDT
Attachment 86437 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8227070
Early Warning System Bot
Comment 3 2011-03-22 01:05:41 PDT
Attachment 86437 [details] did not build on qt: Build output: http://queues.webkit.org/results/8220360
Build Bot
Comment 4 2011-03-22 01:17:57 PDT
Attachment 86437 [details] did not build on win: Build output: http://queues.webkit.org/results/8222154
Yury Semikhatsky
Comment 5 2011-03-22 02:02:54 PDT
Comment on attachment 86437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86437&action=review > Source/WebCore/inspector/Inspector.json:528 > + "id": "DOMNode", I thought we decided to use opaque strings as object/node ids, why should this one be different? > Source/WebCore/inspector/InspectorDOMAgent.cpp:703 > + *errorString = "Can only set value of the text node."; "Can only set value of the text node." -> "Can only set value of text nodes."
Pavel Feldman
Comment 6 2011-03-22 02:11:59 PDT
Created attachment 86444 [details] Patch
Pavel Feldman
Comment 7 2011-03-22 06:51:05 PDT
Committed r81663: <http://trac.webkit.org/changeset/81663>
Note You need to log in before you can comment on or make changes to this bug.