Bug 56781

Summary: Add --dsym switch to enable dsym generation when building with Xcode
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: dev+webkit, joepeck, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch joepeck: review+

David Kilzer (:ddkilzer)
Reported 2011-03-21 16:49:45 PDT
Created attachment 86387 [details] Patch Reviewed by NOBODY (OOPS!). * Scripts/build-webkit: Updated usage statement to include --dsym. * Scripts/webkitdirs.pm: Added $generateDsym variable. (generateDsym): Added. Call determineGenerateDsym() and return $generateDsym. (determineGenerateDsym): Added. Parse @ARGV for --dsym and set $generateDsym. (argumentsForXcode): Added. Returns additional arguments for xcodebuild based on command-line switches. (XcodeOptions): Updated to include argumentsForXcode() in the array returned. --- 3 files changed, 40 insertions(+), 1 deletions(-)
Attachments
Patch (2.96 KB, patch)
2011-03-21 16:49 PDT, David Kilzer (:ddkilzer) 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2011-03-21 17:01:51 PDT
<rdar://problem/9136759>
Joseph Pecoraro
Comment 2 2011-03-21 19:09:45 PDT
Comment on attachment 86387 [details] Patch I notice some of the Perl functions do not use the optional "()" for empty arguments. I'm happy with either style. Nice!
David Kilzer (:ddkilzer)
Comment 3 2011-03-22 13:40:46 PDT
Committed r81690: <http://trac.webkit.org/changeset/81690>
Note You need to log in before you can comment on or make changes to this bug.