Bug 56685
| Summary: | [Mac] webarchive/test-link-rel-icon.html fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | commit-queue, ddkilzer, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Brady Eidson
After a checkin in https://bugs.webkit.org/show_bug.cgi?id=56425 webarchive/test-link-rel-icon.html is now flaky.
I haven't been able to reproduce it locally on any OS.
There's a number of bots that don't show it at all.
I also cannot reproduce on the Leopard bot that showed the failure once after not showing it.
I *can* reproduce on the snow leopard bot that shows the failure.
It appears it's now in "flaky" territory, so we're adding it to the skipped list.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brady Eidson
Added to the skipped list in 81514
Brady Eidson
Found a machine that could reproduce the issue that we could actually debug on.
The patch that changed this subtly delayed the favicon load asynchronously. That was enough to throw off this test, which relies on the synchronous behavior of creating a webarchive.
There's currently no way for a web page to know if/when the icon has loaded. To make this test work properly again, we'd have to add such a way.
In it's current state the test is invalid. I'll chew on ways to make a valid version for a bit.
David Kilzer (:ddkilzer)
*** Bug 56663 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Now this test fails consistently.