Bug 56684

Summary: Full Screen: disable keyboard access by default
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebCore Misc.Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, mitz, svillar, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mjs: review+, jer.noble: commit-queue+

Jer Noble
Reported 2011-03-18 14:38:06 PDT
WebKit should disallow full screen requests with keyboard access.
Attachments
Patch (14.83 KB, patch)
2011-03-26 00:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (14.86 KB, patch)
2011-03-26 01:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (14.86 KB, patch)
2011-03-26 11:27 PDT, Jer Noble 		mjs: review+
jer.noble: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-18 14:38:22 PDT
<rdar://problem/9156540>
Jer Noble
Comment 2 2011-03-26 00:59:19 PDT
Created attachment 87019 [details] Patch
Jer Noble
Comment 3 2011-03-26 01:12:24 PDT
Created attachment 87020 [details] Patch Fixed a compile warning due to an unused parameter.
WebKit Review Bot
Comment 4 2011-03-26 04:59:34 PDT
Attachment 87020 [details] did not build on mac: Build output: http://queues.webkit.org/results/8259049
Jer Noble
Comment 5 2011-03-26 11:27:19 PDT
Created attachment 87031 [details] Patch Fixed the mac EWS build errors.
Maciej Stachowiak
Comment 6 2011-03-26 18:22:09 PDT
Comment on attachment 87031 [details] Patch r=me
WebKit Review Bot
Comment 7 2011-03-27 14:24:12 PDT
Attachment 87031 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8262803
Jer Noble
Comment 8 2011-03-27 21:28:16 PDT
Committed r82084: <http://trac.webkit.org/changeset/82084>
Sergio Villar Senin
Comment 9 2011-03-28 02:36:33 PDT
(In reply to comment #8) > Committed r82084: <http://trac.webkit.org/changeset/82084> Several fullscreen tests started to fail on GTK+ bots after this change. I filed https://bugs.webkit.org/show_bug.cgi?id=57219 and skipped them while it isn't fixed.
Sergio Villar Senin
Comment 10 2011-03-28 03:59:20 PDT
(In reply to comment #9) > (In reply to comment #8) > > Committed r82084: <http://trac.webkit.org/changeset/82084> > > Several fullscreen tests started to fail on GTK+ bots after this change. I filed https://bugs.webkit.org/show_bug.cgi?id=57219 and skipped them while it isn't fixed. Looks like we need to adapt some code in the chromeclient
mitz
Comment 11 2018-10-03 21:17:18 PDT
Comment on attachment 87031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87031&action=review > Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:976 > + SEL selector = @selector(webView:supportsFullScreenForElement:withKeyboard:); The method declaration in the delegate protocol was never changed to include the withKeyboard: argument.
Note You need to log in before you can comment on or make changes to this bug.