Bug 56671

Summary: Add ObjC bindings to the WebCore GYP build
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-03-18 13:35:36 PDT
Add ObjC bindings to the WebCore GYP build
Attachments
Patch (62.23 KB, patch)
2011-03-18 13:39 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-18 13:39:41 PDT
Created attachment 86204 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-18 14:07:16 PDT
Comment on attachment 86204 [details] Patch Seems we should have an exclusion list instead of removing them from teh gypi, but OK.
Adam Barth
Comment 3 2011-03-18 14:09:07 PDT
> Seems we should have an exclusion list instead of removing them from teh gypi, but OK. I think we just blindly run all the IDL files through the ObjC code generator. Many of those files don't even build.
Eric Seidel (no email)
Comment 4 2011-03-18 14:18:32 PDT
Yes, we do just run them all through. I just thought it was more gyp-like to have a black list instead of a white list.
Adam Barth
Comment 5 2011-03-18 14:21:47 PDT
(In reply to comment #4) > Yes, we do just run them all through. I just thought it was more gyp-like to have a black list instead of a white list. My thought is that the extra files don't really "exist" in the sense that no one wants to build them. It probably depends on whether the default policy for new IDL files is to include them in the ObjC bindings. My sense is "no" given how these files have been treated previously.
WebKit Commit Bot
Comment 6 2011-03-18 15:12:19 PDT
The commit-queue encountered the following flaky tests while processing attachment 86204 [details]: webarchive/test-link-rel-icon.html bug 56663 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-03-18 15:14:22 PDT
Comment on attachment 86204 [details] Patch Clearing flags on attachment: 86204 Committed r81517: <http://trac.webkit.org/changeset/81517>
WebKit Commit Bot
Comment 8 2011-03-18 15:14:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.