| Summary: | Add ObjC bindings to the WebCore GYP build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 55018 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-03-18 13:35:36 PDT
Created attachment 86204 [details]
Patch
Comment on attachment 86204 [details]
Patch
Seems we should have an exclusion list instead of removing them from teh gypi, but OK.
> Seems we should have an exclusion list instead of removing them from teh gypi, but OK.
I think we just blindly run all the IDL files through the ObjC code generator. Many of those files don't even build.
Yes, we do just run them all through. I just thought it was more gyp-like to have a black list instead of a white list. (In reply to comment #4) > Yes, we do just run them all through. I just thought it was more gyp-like to have a black list instead of a white list. My thought is that the extra files don't really "exist" in the sense that no one wants to build them. It probably depends on whether the default policy for new IDL files is to include them in the ObjC bindings. My sense is "no" given how these files have been treated previously. The commit-queue encountered the following flaky tests while processing attachment 86204 [details]: webarchive/test-link-rel-icon.html bug 56663 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 86204 [details] Patch Clearing flags on attachment: 86204 Committed r81517: <http://trac.webkit.org/changeset/81517> All reviewed patches have been landed. Closing bug. |