Bug 56656

Summary:

[chromium] add a build target to make a zip file with the inspector debug files

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

Tony Chang

Reported 2011-03-18 10:34:16 PDT

[chromium] add a build target to make a zip file with the inspector debug files

Attachments
Patch (13.14 KB, patch) 2011-03-18 10:36 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Patch (13.27 KB, patch) 2011-03-18 11:03 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Patch (13.27 KB, patch) 2011-03-21 17:13 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Patch for landing (13.15 KB, patch) 2011-04-27 09:50 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2011-03-18 10:36:16 PDT

Created attachment 86177 [details] Patch

Tony Chang

Comment 2 2011-03-18 10:54:55 PDT

Comment on attachment 86177 [details] Patch still working out some build issues and testing on windows

Tony Chang

Comment 3 2011-03-18 11:03:37 PDT

Created attachment 86180 [details] Patch

Tony Chang

Comment 4 2011-03-18 11:07:50 PDT

On Windows, the target doesn't show up in chrome/chrome.sln (since we don't pull in the target), but it does show up in build/all.sln. I think this is fine since the buildbots use all.sln. This is chromium bug http://code.google.com/p/chromium/issues/detail?id=76553

Tony Chang

Comment 5 2011-03-21 17:13:01 PDT

Created attachment 86392 [details] Patch

Tony Chang

Comment 6 2011-03-21 17:13:48 PDT

(In reply to comment #5) > Created an attachment (id=86392) [details] > Patch Rebased the patch after bug 56661 landed. Maybe yurys would like to review?

Pavel Feldman

Comment 7 2011-04-27 07:59:41 PDT

Comment on attachment 86392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86392&action=review I checked that it generates healthy front-end archive, which means that it is working :) > Source/WebKit/chromium/WebKit.gyp:812 > + 'outputs': ['<(PRODUCT_DIR)/inspector_resources.zip'], Could we name this devtools_resources.zip or devtools_frontend.zip instead? > Source/WebKit/chromium/WebKit.gyp:813 > + 'action': ['python', '<@(_script_name)', '<@(_inspector_html)', Could we generate zip with resources/inspector as a base directory? Otherwise, all entries in the zip file have resources/inspector prefixes.

Tony Chang

Comment 8 2011-04-27 09:50:28 PDT

Created attachment 91303 [details] Patch for landing

Tony Chang

Comment 9 2011-04-27 09:51:06 PDT

Comment on attachment 86392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86392&action=review >> Source/WebKit/chromium/WebKit.gyp:812 >> + 'outputs': ['<(PRODUCT_DIR)/inspector_resources.zip'], > > Could we name this devtools_resources.zip or devtools_frontend.zip instead? Renamed to devtools_frontend.zip >> Source/WebKit/chromium/WebKit.gyp:813 >> + 'action': ['python', '<@(_script_name)', '<@(_inspector_html)', > > Could we generate zip with resources/inspector as a base directory? Otherwise, all entries in the zip file have resources/inspector prefixes. Done (removed kBaseDir in the python script).

Tony Chang

Comment 10 2011-04-27 11:58:16 PDT

Committed r85071: <http://trac.webkit.org/changeset/85071>

Note You need to log in before you can comment on or make changes to this bug.