Bug 56646

Summary:

Web Inspector: rename console agent events

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[patch] initial version	none

Ilya Tikhonovsky

Reported 2011-03-18 08:08:47 PDT

addConsoleMessage -> consoleMessage updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate

Attachments
[patch] initial version (7.45 KB, patch) 2011-03-18 08:13 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2011-03-18 08:13:29 PDT

Created attachment 86166 [details] [patch] initial version

WebKit Review Bot

Comment 2 2011-03-18 08:46:35 PDT

Attachment 86166 [details] did not build on mac: Build output: http://queues.webkit.org/results/8198371

Ilya Tikhonovsky

Comment 3 2011-03-18 12:58:32 PDT

landed as r81499

Pavel Feldman

Comment 4 2011-03-18 13:18:42 PDT

Comment on attachment 86166 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=86166&action=review > Source/WebCore/inspector/Inspector.idl:77 > + [event] void consoleMessageExpiredCountUpdate(out unsigned long count); I think these should have been: "messageAdded", "expiredCountUpdated", "repeatCountUpdated"

Pavel Feldman

Comment 5 2011-03-18 13:21:43 PDT

> "expiredCountUpdated", In fact, this one should just be removed - it should become an out parameter in the "setConsoleMessagesEnabled". Which should be renamed to "enable" :)

Note You need to log in before you can comment on or make changes to this bug.