Bug 56624

Summary: [CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, paroga, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 63741    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Ryuan Choi 2011-03-17 20:16:58 PDT 
It's first step to support v8 on EFL build as an option.
Comment 1 Ryuan Choi 2011-03-17 20:22:16 PDT 
Created attachment 86132 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-03-18 00:13:58 PDT 
Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future.
Comment 3 Ryuan Choi 2011-03-18 01:36:24 PDT 
Created attachment 86146 [details]
Patch
Comment 4 Ryuan Choi 2011-03-18 01:39:05 PDT 
(In reply to comment #2)
> Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future.

Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake.
Comment 5 Patrick R. Gansterer 2011-03-18 03:08:02 PDT 
(In reply to comment #4)
> (In reply to comment #2)
> > Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future.
> 
> Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake.

Sorry for my short comment: I'd prefer UseJSC.cmake, corresponding to USE(JSC).
IMHO the V8 part should be named UseV8.cmake.

BTW: I think PlatformEFL.cmake and PlatformWinCE.cmake would be better compared to CMakeListsEFL.txt and CMakeListsWinCE.txt.
Comment 6 Ryuan Choi 2011-03-18 03:58:48 PDT 
Created attachment 86154 [details]
Patch
Comment 7 Ryuan Choi 2011-03-18 04:05:13 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future.
> > 
> > Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake.
> 
> Sorry for my short comment: I'd prefer UseJSC.cmake, corresponding to USE(JSC).
> IMHO the V8 part should be named UseV8.cmake.

No problem, I updated.

> 
> BTW: I think PlatformEFL.cmake and PlatformWinCE.cmake would be better compared to CMakeListsEFL.txt and CMakeListsWinCE.txt.

It looks no problem just for me.
If other guys have no objection, I will prepare it.
Comment 8 Eric Seidel (no email) 2011-03-18 14:21:13 PDT 
Comment on attachment 86154 [details]
Patch

rs=me.
Comment 9 WebKit Commit Bot 2011-03-18 14:52:10 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86154 [details]:

webarchive/test-link-rel-icon.html bug 56663 (author: ddkilzer@webkit.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2011-03-18 14:55:39 PDT 
Comment on attachment 86154 [details]
Patch

Clearing flags on attachment: 86154

Committed r81515: <http://trac.webkit.org/changeset/81515>
Comment 11 WebKit Commit Bot 2011-03-18 14:55:45 PDT 
All reviewed patches have been landed.  Closing bug.