Bug 56604

Summary: WebCore GYP build should have PrivateHeaders
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Adam Barth 2011-03-17 15:56:30 PDT
WebCore GYP build should have PrivateHeaders
Comment 1 Adam Barth 2011-03-17 15:58:01 PDT
Created attachment 86105 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-17 16:03:59 PDT
Comment on attachment 86105 [details]
Patch

OK.  Seems we probably want a double-list or a filtered set of all sources or something instead of this eventually.
Comment 3 Adam Barth 2011-03-17 16:16:22 PDT
Yeah, tried some of those things for JavaScriptCore.  This approach seemed better than listing the same files twice, but I'm open to changing this to be more aesthetic.
Comment 4 Adam Barth 2011-03-17 16:41:54 PDT
Created attachment 86112 [details]
Patch for landing
Comment 5 Adam Barth 2011-03-17 16:49:24 PDT
Created attachment 86115 [details]
Patch for landing
Comment 6 Adam Barth 2011-03-17 17:13:01 PDT
Created attachment 86120 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2011-03-17 18:36:42 PDT
Comment on attachment 86120 [details]
Patch for landing

Clearing flags on attachment: 86120

Committed r81424: <http://trac.webkit.org/changeset/81424>
Comment 8 WebKit Commit Bot 2011-03-17 18:36:46 PDT
All reviewed patches have been landed.  Closing bug.