Summary: | WebCore GYP build should have PrivateHeaders | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, eric | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 55018 | ||||||||||||
Attachments: |
|
Description
Adam Barth
2011-03-17 15:56:30 PDT
Created attachment 86105 [details]
Patch
Comment on attachment 86105 [details]
Patch
OK. Seems we probably want a double-list or a filtered set of all sources or something instead of this eventually.
Yeah, tried some of those things for JavaScriptCore. This approach seemed better than listing the same files twice, but I'm open to changing this to be more aesthetic. Created attachment 86112 [details]
Patch for landing
Created attachment 86115 [details]
Patch for landing
Created attachment 86120 [details]
Patch for landing
Comment on attachment 86120 [details] Patch for landing Clearing flags on attachment: 86120 Committed r81424: <http://trac.webkit.org/changeset/81424> All reviewed patches have been landed. Closing bug. |