Bug 56590

Summary:	Rename setMarkedText to setMarkedTextAndSelectionWithin
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Enhancement	CC:	ap, benjamin, darin, dbates, enrica, mjs, robert, suzhe
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	All
OS:	All

Ryosuke Niwa

Reported 2011-03-17 14:08:23 PDT

In the discussion on IRC, we came to conclusion that setMarkedText is a confusing function because it sets marked text and also selection within the marked text. This confusion resulted in an incorrect layout test change in http://trac.webkit.org/changeset/80064. We should rename this function to setMarkedTextAndSelectionWithin so that we don't make similar mistakes in the future.

Attachments
Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2011-03-17 14:32:28 PDT

This bug is about a TextInputController method that's exposing setMarkedText:selectedRange: AppKit method.

Note You need to log in before you can comment on or make changes to this bug.