Bug 56589

Summary: WebKit2: Cancelling full screen early leaves full screen window up.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Jer Noble
Reported 2011-03-17 14:03:44 PDT
WebKit2: Cancelling full screen early leaves full screen window up.
Attachments
Patch (3.76 KB, patch)
2011-03-17 14:11 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.84 KB, patch)
2011-03-24 14:09 PDT, Jer Noble 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-17 14:11:11 PDT
Created attachment 86092 [details] Patch
Jer Noble
Comment 2 2011-03-17 14:24:01 PDT
<rdar://problem/9150807>
Eric Seidel (no email)
Comment 3 2011-03-18 14:23:22 PDT
Comment on attachment 86092 [details] Patch Seems reasonable. Can this be tested?
Jer Noble
Comment 4 2011-03-18 15:16:34 PDT
(In reply to comment #3) > (From update of attachment 86092 [details]) > Seems reasonable. Can this be tested? Depends. If you mean, can the testing be automated, unfortunately no. The WebKitTestRunner doesn't support the new full screen APIs yet. But it can be manually tested by enabling WebKit's full screen mode in Safari: > defaults write com.apple.Safari WebKitFullScreenEnabled -bool true
Maciej Stachowiak
Comment 5 2011-03-23 18:01:26 PDT
Comment on attachment 86092 [details] Patch r=me , please add a ChangeLog comment explaining why an automated test is not possible at this time.
Jer Noble
Comment 6 2011-03-24 14:09:28 PDT
Created attachment 86834 [details] Patch When prepping this patch for checkin, I realized a piece was in a separate commit, and never was reviewed. Re-uploading a patch with changes to WebFullScreenManagerMac.mm attached.
Maciej Stachowiak
Comment 7 2011-03-24 14:29:07 PDT
Comment on attachment 86834 [details] Patch r=me
Jer Noble
Comment 8 2011-03-24 14:46:08 PDT
Committed r81901: <http://trac.webkit.org/changeset/81901>
Note You need to log in before you can comment on or make changes to this bug.