Bug 56574

Summary: Dealloc'ing a WKView can leave a stale reference to it in NSWindow
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit2Assignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch to clear growBoxOwner at the appropriate time. aroben: review+

John Sullivan
Reported 2011-03-17 10:49:19 PDT
WKView is setting itself as the window's _growBoxOwner in an override of _updateGrowBoxForWindowFrameChange, but isn't clearing it at any point. NSWindow doesn't retain/release its growBoxOwner, so this can lead to a bad object ref in NSWindow that results in crashes.
Attachments
Patch to clear growBoxOwner at the appropriate time. (1.70 KB, patch)
2011-03-17 10:53 PDT, John Sullivan 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2011-03-17 10:53:29 PDT
Created attachment 86069 [details] Patch to clear growBoxOwner at the appropriate time.
John Sullivan
Comment 2 2011-03-17 11:41:43 PDT
Committed in http://trac.webkit.org/changeset/81372
Note You need to log in before you can comment on or make changes to this bug.