Bug 56549
| Summary: | Non-ASCII characters in XMLTreeViewer.{cpp,h} | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yuta Kitamura <yutak> |
| Component: | WebCore Misc. | Assignee: | Yuta Kitamura <yutak> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, eric, pfeldman, vsevik, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
Yuta Kitamura
The license statement in WebCore/xml/XMLTreeViewer.{cpp,h} contains non-ASCII characters (quotes surrounding "AS IS").
These characters caused a compile error on my local Windows build environment:
> ..\xml\XMLTreeViewer.cpp : error C2220: warning treated as error - no 'object' file generated
> ..\xml\XMLTreeViewer.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
Code page 932 means Japanese locale; Visual Studio seems to complain about these characters if the system locale is set to Japanese.
These source files were added in r79861 (bug 13807).
I will work on a patch for this. Since this is a build fix and the fix is simple, I will commit it as unreviewed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yuta Kitamura
Committed r81335: <http://trac.webkit.org/changeset/81335>
WebKit Review Bot
http://trac.webkit.org/changeset/81335 might have broken SnowLeopard Intel Release (WebKit2 Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html