Summary: | Need to do an experiment to make sure that reftests don't cause any issues on all buildbots | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dpranke, hamaji, ojan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 36065 | ||||||||
Attachments: |
|
Description
Hayato Ito
2011-03-15 23:18:23 PDT
Created attachment 85913 [details]
the-first-reftest
I've checked it as 'r?', but I won't submit this patch soon until all necessary changes are landed. Comment on attachment 85913 [details]
the-first-reftest
What identifies this as a reftest? expected.html I assume?
Yeah, we use a naming convention to identify. Please see a master bug to know how and why: https://bugs.webkit.org/show_bug.cgi?id=36065 And the Wiki page I started to write is here: http://trac.webkit.org/wiki/Writing%20Reftests (In reply to comment #3) > (From update of attachment 85913 [details]) > What identifies this as a reftest? expected.html I assume? Comment on attachment 85913 [details]
the-first-reftest
Seems this should go into the harness directory (which is about testing DRT/RWT) since this test doesn't really add much to our CSS testing.
This is an experiment reftest, so the test itself doesn't matter. If you think this test doesn't add much to our css testing, I am happy to revert it after we confirm all buildbots are happy with this reftest. We decided to use LayoutTest directory to where '-expected.html' is added as other existing LayoutTests do. So '-expected.html' must go into LayoutTests directory to do an experiment. (In reply to comment #5) > (From update of attachment 85913 [details]) > Seems this should go into the harness directory (which is about testing DRT/RWT) since this test doesn't really add much to our CSS testing. I think Eric was just saying that the test should go in fast/harness instead of fast/css. Created attachment 86293 [details]
move-to-harness
Hi Ojan, thank you for clarifying that. Although I am not 100% sure what the purpose of the 'fast/harness' directory is, I've moved the test to 'fast/harness' directory. Could you review it? (In reply to comment #7) > I think Eric was just saying that the test should go in fast/harness instead of fast/css. Committed r81644: <http://trac.webkit.org/changeset/81644> |