Bug 56438

Summary: Make Structure creation require a JSGlobalData
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch ggaren: review+

Oliver Hunt
Reported 2011-03-15 18:21:57 PDT
Make Structure creation require a JSGlobalData
Attachments
Patch (121.49 KB, patch)
2011-03-15 18:26 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (123.00 KB, patch)
2011-03-16 10:05 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (123.99 KB, patch)
2011-03-16 10:27 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (127.29 KB, patch)
2011-03-16 11:00 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (127.99 KB, patch)
2011-03-16 11:27 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (128.12 KB, patch)
2011-03-16 11:41 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-03-15 18:26:06 PDT
Created attachment 85892 [details] Patch
Early Warning System Bot
Comment 2 2011-03-15 18:44:00 PDT
Attachment 85892 [details] did not build on qt: Build output: http://queues.webkit.org/results/8177787
Build Bot
Comment 3 2011-03-15 21:52:45 PDT
Attachment 85892 [details] did not build on win: Build output: http://queues.webkit.org/results/8177848
WebKit Review Bot
Comment 4 2011-03-16 01:55:47 PDT
Attachment 85892 [details] did not build on mac: Build output: http://queues.webkit.org/results/8187066
Oliver Hunt
Comment 5 2011-03-16 10:05:45 PDT
Created attachment 85937 [details] Patch Include missing change that broke qt,mac,etc and remove exports from windows
Early Warning System Bot
Comment 6 2011-03-16 10:19:56 PDT
Attachment 85937 [details] did not build on qt: Build output: http://queues.webkit.org/results/8187233
Oliver Hunt
Comment 7 2011-03-16 10:27:37 PDT
Created attachment 85939 [details] Patch Include change properly this time
Build Bot
Comment 8 2011-03-16 10:35:17 PDT
Attachment 85937 [details] did not build on win: Build output: http://queues.webkit.org/results/8193079
Early Warning System Bot
Comment 9 2011-03-16 10:43:47 PDT
Attachment 85939 [details] did not build on qt: Build output: http://queues.webkit.org/results/8193082
Oliver Hunt
Comment 10 2011-03-16 11:00:58 PDT
Created attachment 85942 [details] Patch Fix QT
Early Warning System Bot
Comment 11 2011-03-16 11:25:28 PDT
Attachment 85942 [details] did not build on qt: Build output: http://queues.webkit.org/results/8191143
Oliver Hunt
Comment 12 2011-03-16 11:27:41 PDT
Created attachment 85945 [details] Patch Fix QT again
Build Bot
Comment 13 2011-03-16 11:36:47 PDT
Attachment 85942 [details] did not build on win: Build output: http://queues.webkit.org/results/8188278
Oliver Hunt
Comment 14 2011-03-16 11:41:32 PDT
Created attachment 85950 [details] Patch Fix windows build
Build Bot
Comment 15 2011-03-16 12:04:41 PDT
Attachment 85939 [details] did not build on win: Build output: http://queues.webkit.org/results/8189194
Geoffrey Garen
Comment 16 2011-03-16 12:13:17 PDT
Comment on attachment 85950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85950&action=review r=me if this builds and you make the change below. > Source/JavaScriptCore/runtime/JSGlobalData.cpp:144 > + , dummyMarkableCellStructure(JSCell::createDummyStructure(*this)) Please ensure these are initialized after heap. You need to verify that moving the heap data member is not a performance regression. Previously, SunSpider has shown itself to be sensitive to the location of some of those data members.
Oliver Hunt
Comment 17 2011-03-16 13:14:27 PDT
Committed r81272: <http://trac.webkit.org/changeset/81272>
WebKit Review Bot
Comment 18 2011-03-16 14:19:52 PDT
http://trac.webkit.org/changeset/81272 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: java/lc3/JSObject/ToObject-001.html
Note You need to log in before you can comment on or make changes to this bug.