Summary: | Make Structure creation require a JSGlobalData | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, buildbot, eric, webkit-ews, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Other | ||||||||||||||||
OS: | OS X 10.5 | ||||||||||||||||
Attachments: |
|
Description
Oliver Hunt
2011-03-15 18:21:57 PDT
Created attachment 85892 [details]
Patch
Attachment 85892 [details] did not build on qt: Build output: http://queues.webkit.org/results/8177787 Attachment 85892 [details] did not build on win: Build output: http://queues.webkit.org/results/8177848 Attachment 85892 [details] did not build on mac: Build output: http://queues.webkit.org/results/8187066 Created attachment 85937 [details]
Patch
Include missing change that broke qt,mac,etc and remove exports from windows
Attachment 85937 [details] did not build on qt: Build output: http://queues.webkit.org/results/8187233 Created attachment 85939 [details]
Patch
Include change properly this time
Attachment 85937 [details] did not build on win: Build output: http://queues.webkit.org/results/8193079 Attachment 85939 [details] did not build on qt: Build output: http://queues.webkit.org/results/8193082 Created attachment 85942 [details]
Patch
Fix QT
Attachment 85942 [details] did not build on qt: Build output: http://queues.webkit.org/results/8191143 Created attachment 85945 [details]
Patch
Fix QT again
Attachment 85942 [details] did not build on win: Build output: http://queues.webkit.org/results/8188278 Created attachment 85950 [details]
Patch
Fix windows build
Attachment 85939 [details] did not build on win: Build output: http://queues.webkit.org/results/8189194 Comment on attachment 85950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85950&action=review r=me if this builds and you make the change below. > Source/JavaScriptCore/runtime/JSGlobalData.cpp:144 > + , dummyMarkableCellStructure(JSCell::createDummyStructure(*this)) Please ensure these are initialized after heap. You need to verify that moving the heap data member is not a performance regression. Previously, SunSpider has shown itself to be sensitive to the location of some of those data members. Committed r81272: <http://trac.webkit.org/changeset/81272> http://trac.webkit.org/changeset/81272 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: java/lc3/JSObject/ToObject-001.html |