Bug 56422

Summary: Removed a few more deprecatedAppends, and removed HeapRoot<T>
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Geoffrey Garen
Reported 2011-03-15 15:52:41 PDT
Removed a few more deprecatedAppends, and removed HeapRoot<T>
Attachments
Patch (18.24 KB, patch)
2011-03-15 15:56 PDT, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-03-15 15:56:44 PDT
Created attachment 85867 [details] Patch
WebKit Review Bot
Comment 2 2011-03-15 15:58:25 PDT
Attachment 85867 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/SmallStrings.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2011-03-15 16:14:57 PDT
Comment on attachment 85867 [details] Patch A nice follow up would be a list append to HeapRootMarker that could then be used by HandleStack
Geoffrey Garen
Comment 4 2011-03-15 16:30:01 PDT
Committed r81191: <http://trac.webkit.org/changeset/81191>
WebKit Review Bot
Comment 5 2011-03-15 23:56:55 PDT
http://trac.webkit.org/changeset/81191 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.