Bug 56417

Summary:

[Qt][Symbian][WK2] Fix exporting and importing WebProcessMainQt

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, laszlo.gombos, s.mathur, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

S60 3rd edition

Bug Depends on:

Bug Blocks:

50251

Attachments:

Description	Flags
fix to land for cq+	none

Description Laszlo Gombos 2011-03-15 14:48:51 PDT

Both in WebKit2/qt/MainQt.cpp and in WebKit2/WebProcess/qt/WebProcessMainQt.cpp QWEBKIT_EXPORT is defined to an empty string; so the WebProcessMainQt symbol does not get properly exported/imported. This is likely not only a problem on Symbian/RVCT but on Windows/MSVC as well.

Comment 1 Laszlo Gombos 2011-03-15 15:00:17 PDT

Created attachment 85861 [details]
fix to land for cq+

Fix looks good to me, r+.

Comment 2 WebKit Commit Bot 2011-03-15 15:55:24 PDT

Comment on attachment 85861 [details]
fix to land for cq+

Clearing flags on attachment: 85861

Committed r81186: <http://trac.webkit.org/changeset/81186>

Comment 3 WebKit Commit Bot 2011-03-15 15:55:29 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 WebKit Review Bot 2011-03-15 23:56:44 PDT

http://trac.webkit.org/changeset/81186 might have broken WinCE Release (Build)