Bug 56417

Summary: [Qt][Symbian][WK2] Fix exporting and importing WebProcessMainQt
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, laszlo.gombos, s.mathur, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 50251    
Attachments:
Description Flags
fix to land for cq+ none

Laszlo Gombos
Reported 2011-03-15 14:48:51 PDT
Both in WebKit2/qt/MainQt.cpp and in WebKit2/WebProcess/qt/WebProcessMainQt.cpp QWEBKIT_EXPORT is defined to an empty string; so the WebProcessMainQt symbol does not get properly exported/imported. This is likely not only a problem on Symbian/RVCT but on Windows/MSVC as well.
Attachments
fix to land for cq+ (2.11 KB, patch)
2011-03-15 15:00 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-03-15 15:00:17 PDT
Created attachment 85861 [details] fix to land for cq+ Fix looks good to me, r+.
WebKit Commit Bot
Comment 2 2011-03-15 15:55:24 PDT
Comment on attachment 85861 [details] fix to land for cq+ Clearing flags on attachment: 85861 Committed r81186: <http://trac.webkit.org/changeset/81186>
WebKit Commit Bot
Comment 3 2011-03-15 15:55:29 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2011-03-15 23:56:44 PDT
http://trac.webkit.org/changeset/81186 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.