Bug 56403

Summary: [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: MediaAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch. none

Alexis Menard (darktears)
Reported 2011-03-15 13:02:17 PDT
In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING); As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched i.e the pause() made when beginScrubbing is done is just internal.
Attachments
Proposed patch. (2.00 KB, patch)
2011-03-15 13:07 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-03-15 13:07:30 PDT
Created attachment 85845 [details] Proposed patch.
Martin Robinson
Comment 2 2011-03-15 15:52:34 PDT
Comment on attachment 85845 [details] Proposed patch. Looks good to me, but I'd like Philippe to take a look at this as well before you land it.
Philippe Normand
Comment 3 2011-03-16 01:49:08 PDT
Comment on attachment 85845 [details] Proposed patch. Yep I discussed about this patch with Alexis, I tested it on GTK, no regression spotted!
WebKit Commit Bot
Comment 4 2011-03-16 03:37:08 PDT
The commit-queue encountered the following flaky tests while processing attachment 85845 [details]: transitions/interrupted-accelerated-transition.html bug 56242 (authors: simon.fraser@apple.com and tonyg@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-03-16 03:44:39 PDT
Comment on attachment 85845 [details] Proposed patch. Clearing flags on attachment: 85845 Committed r81234: <http://trac.webkit.org/changeset/81234>
WebKit Commit Bot
Comment 6 2011-03-16 03:44:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.