Summary: | Valgrind error due to uninitialized PluginLayerChromium::m_textureId | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alok Priyadarshi <alokp> | ||||||||
Component: | Plug-ins | Assignee: | Alok Priyadarshi <alokp> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jamesr, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alok Priyadarshi
2011-03-15 11:14:45 PDT
Created attachment 85834 [details]
proposed patch
Initialized member variable and also addressed your comment about function naming.
Comment on attachment 85834 [details] proposed patch Rejecting attachment 85834 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: ching file Source/WebKit/chromium/public/WebPlugin.h Hunk #1 FAILED at 64. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/public/WebPlugin.h.rej patching file Source/WebKit/chromium/src/WebPluginContainerImpl.cpp Hunk #2 FAILED at 443. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/src/WebPluginContainerImpl.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'James Robinson', u'--f..." exit_code: 1 Full output: http://queues.webkit.org/results/8178621 Created attachment 85837 [details]
proposed patch
Sorry the last patch also included changes from an earlier CL. Now from the correct client.
Attachment 85837 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:75: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 7 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 85837 [details]
proposed patch
wrong patch
Created attachment 85838 [details]
proposed patch
The commit-queue encountered the following flaky tests while processing attachment 85838 [details]: transitions/interrupted-accelerated-transition.html bug 56242 (authors: simon.fraser@apple.com and tonyg@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 85838 [details] proposed patch Clearing flags on attachment: 85838 Committed r81169: <http://trac.webkit.org/changeset/81169> All reviewed patches have been landed. Closing bug. |