Bug 56370

Summary: [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch eric.carlson: review+

Philippe Normand
Reported 2011-03-15 03:28:15 PDT
Diff: --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/media/video-play-stall-before-meta-data-expected.txt 2011-03-15 03:05:36.457251353 -0700 +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/media/video-play-stall-before-meta-data-actual.txt 2011-03-15 03:05:36.457251353 -0700 @@ -2,7 +2,6 @@ EVENT(beforeload) EVENT(loadstart) -EVENT(stalled) EVENT(window.onload) END OF TEST I think the test fails because our player errors out and resets its network state too early, preventing HTMLMediaElement::progressEventTimerFired to emit the stalled event. I'll skip the test on GTK for now and work on a fix for this issue.
Attachments
proposed patch (3.53 KB, patch)
2011-03-15 04:54 PDT, Philippe Normand 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-03-15 03:38:00 PDT
Skipped in http://trac.webkit.org/changeset/81125
Philippe Normand
Comment 2 2011-03-15 04:54:34 PDT
Created attachment 85796 [details] proposed patch
Philippe Normand
Comment 3 2011-03-16 01:57:28 PDT
Committed r81229: <http://trac.webkit.org/changeset/81229>
Joseph Pecoraro
Comment 4 2011-03-16 10:25:31 PDT
Thanks for fixing this Philippe. I didn't even notice it failed on gtk.
Note You need to log in before you can comment on or make changes to this bug.