Bug 56364

Summary: Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Product: WebKit Reporter: Ilya Sherman <isherman>
Component: New BugsAssignee: Ilya Sherman <isherman>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, fishd, isherman, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Ilya Sherman
Reported 2011-03-14 23:57:16 PDT
Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Attachments
Patch (2.18 KB, patch)
2011-03-14 23:58 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2011-03-18 15:27 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Sherman
Comment 1 2011-03-14 23:58:09 PDT
Created attachment 85782 [details] Patch
WebKit Review Bot
Comment 2 2011-03-15 00:05:54 PDT
Attachment 85782 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8174522
Ilya Sherman
Comment 3 2011-03-15 00:40:36 PDT
(In reply to comment #2) > Attachment 85782 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/8174522 The file that's triggering this compile error is stale -- it doesn't exist anymore in the Chromium repository as of crrev.com/77840 Adam Barth suggested that I should update the Source/WebKit/chromium/DEPS file, but Dave Levin mentioned that this file can't be rolled right now due to a potentially inadvertently added dependency. So... guess I'll just wait for now and let that get sorted out =)
Eric Seidel (no email)
Comment 4 2011-03-18 15:03:22 PDT
Comment on attachment 85782 [details] Patch Looks like cr-linux is sad?
Ilya Sherman
Comment 5 2011-03-18 15:27:20 PDT
Created attachment 86227 [details] Patch
Ilya Sherman
Comment 6 2011-03-18 15:28:06 PDT
Rebased; cr-linux should cheer right up
Ilya Sherman
Comment 7 2011-03-21 15:57:41 PDT
Ping :)
James Robinson
Comment 8 2011-03-21 16:06:59 PDT
Comment on attachment 86227 [details] Patch I always like removing API!
WebKit Commit Bot
Comment 9 2011-03-21 20:06:39 PDT
Comment on attachment 86227 [details] Patch Clearing flags on attachment: 86227 Committed r81637: <http://trac.webkit.org/changeset/81637>
WebKit Commit Bot
Comment 10 2011-03-21 20:06:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.