Summary: | Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Sherman <isherman> | ||||||
Component: | New Bugs | Assignee: | Ilya Sherman <isherman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, fishd, isherman, jamesr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Ilya Sherman
2011-03-14 23:57:16 PDT
Created attachment 85782 [details]
Patch
Attachment 85782 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8174522 (In reply to comment #2) > Attachment 85782 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/8174522 The file that's triggering this compile error is stale -- it doesn't exist anymore in the Chromium repository as of crrev.com/77840 Adam Barth suggested that I should update the Source/WebKit/chromium/DEPS file, but Dave Levin mentioned that this file can't be rolled right now due to a potentially inadvertently added dependency. So... guess I'll just wait for now and let that get sorted out =) Comment on attachment 85782 [details]
Patch
Looks like cr-linux is sad?
Created attachment 86227 [details]
Patch
Rebased; cr-linux should cheer right up Ping :) Comment on attachment 86227 [details]
Patch
I always like removing API!
Comment on attachment 86227 [details] Patch Clearing flags on attachment: 86227 Committed r81637: <http://trac.webkit.org/changeset/81637> All reviewed patches have been landed. Closing bug. |