| Summary: | [chromium] add a build target to create a grd file with devtool resources | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, pfeldman | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tony Chang
2011-03-14 14:11:25 PDT
Created attachment 85717 [details]
Patch
This is the webkit side of http://code.google.com/p/chromium/issues/detail?id=35793 . The next chromium side that uses this is: http://codereview.chromium.org/6685061/ In general, the plan is to put all the files in resources/inspector into resources.pak. To do that, we generate the .grd file with this script, then we run grit on the file which creates devtools.pak which we then merge (repack) into resources.pak. The chromium code will also have to be updated to load the files from resources.pak. Also, this shouldn't change anything for test_shell, DRT or for the debug mode. Comment on attachment 85717 [details]
Patch
Crazy. The Python script is very nice. WebKit.gyp is out of control.
Committed r81147: <http://trac.webkit.org/changeset/81147> Broke on Chromium Win so I reverted: http://trac.webkit.org/changeset/81152 reopening Created attachment 85852 [details]
Patch for landing
Comment on attachment 85852 [details] Patch for landing Clearing flags on attachment: 85852 Committed r81175: <http://trac.webkit.org/changeset/81175> All reviewed patches have been landed. Closing bug. |