Bug 56335

Summary: [chromium] add a build target to create a grd file with devtool resources
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Chang
Reported 2011-03-14 14:11:25 PDT
[chromium] add a build target to create a grd file with devtool resources
Attachments
Patch (7.10 KB, patch)
2011-03-14 14:12 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.41 KB, patch)
2011-03-15 13:37 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-03-14 14:12:13 PDT
Created attachment 85717 [details] Patch
Tony Chang
Comment 2 2011-03-14 14:15:04 PDT
This is the webkit side of http://code.google.com/p/chromium/issues/detail?id=35793 . The next chromium side that uses this is: http://codereview.chromium.org/6685061/ In general, the plan is to put all the files in resources/inspector into resources.pak. To do that, we generate the .grd file with this script, then we run grit on the file which creates devtools.pak which we then merge (repack) into resources.pak. The chromium code will also have to be updated to load the files from resources.pak. Also, this shouldn't change anything for test_shell, DRT or for the debug mode.
Adam Barth
Comment 3 2011-03-15 02:15:31 PDT
Comment on attachment 85717 [details] Patch Crazy. The Python script is very nice. WebKit.gyp is out of control.
Tony Chang
Comment 4 2011-03-15 10:41:07 PDT
Committed r81147: <http://trac.webkit.org/changeset/81147>
Tony Chang
Comment 5 2011-03-15 10:57:09 PDT
Broke on Chromium Win so I reverted: http://trac.webkit.org/changeset/81152
Tony Chang
Comment 6 2011-03-15 10:57:26 PDT
reopening
Tony Chang
Comment 7 2011-03-15 13:37:52 PDT
Created attachment 85852 [details] Patch for landing
WebKit Commit Bot
Comment 8 2011-03-15 14:37:21 PDT
Comment on attachment 85852 [details] Patch for landing Clearing flags on attachment: 85852 Committed r81175: <http://trac.webkit.org/changeset/81175>
WebKit Commit Bot
Comment 9 2011-03-15 14:37:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.