Bug 56296

Summary: Clean up includes/forward declarations in IconDatabaseBase
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Severity: Normal CC: tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52451    
Description Flags
Patch v1
beidson: commit-queue-
Patch v2 - Left out the WebKit pieces
sam: review-, beidson: commit-queue-
Patch v3 sam: review+, beidson: commit-queue-

Description Brady Eidson 2011-03-14 01:47:25 PDT
Clean up includes/forward declarations in IconDatabaseBase

It'd be great to get rid of the "PlatformString.h" include.
Comment 1 Brady Eidson 2011-03-14 01:49:51 PDT
Created attachment 85657 [details]
Patch v1
Comment 2 WebKit Review Bot 2011-03-14 01:51:03 PDT
Attachment 85657 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/loader/icon/IconDatabaseBase.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2011-03-14 10:01:45 PDT
Created attachment 85686 [details]
Patch v2 - Left out the WebKit pieces
Comment 4 Brady Eidson 2011-03-14 10:02:28 PDT
Ignore the "Left out the WebKit pieces" in the patch title - autocomplete, damn you!
Comment 5 Sam Weinig 2011-03-14 10:06:02 PDT
Comment on attachment 85686 [details]
Patch v2 - Left out the WebKit pieces

View in context: https://bugs.webkit.org/attachment.cgi?id=85686&action=review

> Source/WebCore/loader/icon/IconDatabase.h:31
> +#include "PlatformString.h"

This should be <wtf/text/WTFString.h>

> Source/WebCore/loader/icon/IconDatabaseBase.h:34
> +namespace WTF {
> +class String;
> +}

This should use <wtf/Forward.h>

> Source/WebCore/loader/icon/IconDatabaseBase.h:97
> +    virtual WTF::String databasePath() const;

If you use forward.h, the WTF is not necessary.
Comment 6 Brady Eidson 2011-03-14 10:15:41 PDT
Created attachment 85688 [details]
Patch v3