Summary: | Add ability to create a WKErrorRef | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2011-03-13 17:28:52 PDT
Created attachment 85629 [details]
Patch
Attachment 85629 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:130: Missing space before ( in switch( [whitespace/parens] [5]
Source/WebCore/platform/network/cf/ResourceError.h:58: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/network/cf/ResourceError.h:64: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/Shared/API/c/cf/WKErrorCF.h:36: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/Shared/API/c/cf/WKErrorCF.h:37: The parameter name "alloc" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/Shared/API/c/cf/WKErrorCF.h:37: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 7 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
http://trac.webkit.org/changeset/80981 might have broken Windows Release (Build) and Windows Debug (Build) |