Bug 56240

Summary:

Invalid assertion in StorageTracker -- PageGroup::numberOfPageGroups() == 1

Product:

WebKit

Reporter:

Anton D'Auria <adauria>

Component:

WebCore Misc.

Assignee:

Anton D'Auria <adauria>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, jorlow

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	beidson: review+

Anton D'Auria

Reported 2011-03-11 21:04:28 PST

LocalStorage is currently in limbo. It is accessed through separate PageGroup instances with their own StorageNamespace instances, but each PageGroup uses the same path for LocalStorage dbs. Thus, the in-memory versions of those dbs can be out of sync with the db if another PageGroup is writing to it. This has been brought up in https://bugs.webkit.org/show_bug.cgi?id=51878 LocalStorage should either be truly per-PageGroup, or global. Right now it is neither, so until this is fixed, the assertion in StorageTracker -- (PageGroup::numberOfPageGroups() == 1) -- is invalid.

Attachments
Patch (2.27 KB, patch) 2011-03-11 23:11 PST, Anton D'Auria	beidson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anton D'Auria

Comment 1 2011-03-11 21:05:56 PST

I should have stated explicitly that "the in-memory versions of those dbs" are StorageAreas with their HashMap representations of the backing dbs.

Anton D'Auria

Comment 2 2011-03-11 23:11:00 PST

Created attachment 85572 [details] Patch

Brady Eidson

Comment 3 2011-03-13 23:21:15 PDT

Landed in r81002

Brady Eidson

Comment 4 2011-03-13 23:21:59 PDT

We should still track actually clearing up the "am I per-pagegroup or not?" concept here.

Note You need to log in before you can comment on or make changes to this bug.