Bug 56234

Summary:

[chromium] Correct return type of WebClipboard::readImage

Product:

WebKit

Reporter:

Daniel Cheng <dcheng>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dimich, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	tony: review+

Daniel Cheng

Reported 2011-03-11 16:45:37 PST

Change it from a WebImage to WebData to indicate that we are returning a blob of PNG data.

Attachments
Patch (1.60 KB, patch) 2011-03-11 16:50 PST, Daniel Cheng	tony: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Cheng

Comment 1 2011-03-11 16:50:47 PST

Tony Chang

Comment 2 2011-03-11 16:58:11 PST

Comment on attachment 85556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > Source/WebKit/chromium/public/WebClipboard.h:36 > #include "WebImage.h" Can we remove this?

Dmitry Titov

Comment 3 2011-03-11 16:58:50 PST

(In reply to comment #2) > (From update of attachment 85556 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > > > Source/WebKit/chromium/public/WebClipboard.h:36 > > #include "WebImage.h" > > Can we remove this? Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch

Tony Chang

Comment 4 2011-03-11 17:00:17 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 85556 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > > > > > Source/WebKit/chromium/public/WebClipboard.h:36 > > > #include "WebImage.h" > > > > Can we remove this? > > Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch Looks like we'll have to forward declare WebImage because writeImage uses it, which is fine.

Daniel Cheng

Comment 5 2011-03-11 17:02:39 PST

(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 85556 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > > > > > > > Source/WebKit/chromium/public/WebClipboard.h:36 > > > > #include "WebImage.h" > > > > > > Can we remove this? > > > > Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch > > Looks like we'll have to forward declare WebImage because writeImage uses it, which is fine. I will fix this before landing. Thanks!

Daniel Cheng

Comment 6 2011-03-11 17:08:03 PST

Note You need to log in before you can comment on or make changes to this bug.