Bug 56226

Summary: WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebCore Misc.Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 55993    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Jer Noble
Reported 2011-03-11 14:48:24 PST
WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
Attachments
Patch (3.48 KB, patch)
2011-03-11 14:54 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2011-03-11 15:10 PST, Jer Noble 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-11 14:54:47 PST
Created attachment 85541 [details] Patch
WebKit Review Bot
Comment 2 2011-03-11 14:57:44 PST
Attachment 85541 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8132409
Jer Noble
Comment 3 2011-03-11 15:05:54 PST
(In reply to comment #2) > Attachment 85541 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/8132409 Forgot to mark this bug as blocked by #559933, which includes the necessary changes to ChromeClient.h.
Jer Noble
Comment 4 2011-03-11 15:10:24 PST
Created attachment 85545 [details] Patch
WebKit Review Bot
Comment 5 2011-03-11 15:14:35 PST
Attachment 85545 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8135469
Collabora GTK+ EWS bot
Comment 6 2011-03-11 17:44:25 PST
Attachment 85545 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8135536
Eric Seidel (no email)
Comment 7 2011-03-11 19:16:06 PST
Attachment 85545 [details] did not build on mac: Build output: http://queues.webkit.org/results/8148516
Jer Noble
Comment 8 2011-03-11 20:02:35 PST
Committed r80922: <http://trac.webkit.org/changeset/80922>
Jer Noble
Comment 9 2011-03-11 21:03:27 PST
webkit-patch closed the wrong bug. This last commit belongs to #56218.
Jer Noble
Comment 10 2011-03-11 21:29:09 PST
Committed r80926: <http://trac.webkit.org/changeset/80926>
Note You need to log in before you can comment on or make changes to this bug.