Bug 56173

Summary: Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, buildbot, bweinstein, dglazkov, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Patch for landing none

Yury Semikhatsky
Reported 2011-03-11 00:45:45 PST
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost. InjectedScriptHost should only be used by the injected script to access native parts of web inspector. All script managing stuff should go into InjectedScriptManager. Also the plan is to have InspectorController own InjectedScriptManager along with agents.
Attachments
Patch (93.82 KB, patch)
2011-03-11 00:59 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Patch for landing (98.97 KB, patch)
2011-03-11 05:14 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-03-11 00:59:01 PST
Created attachment 85443 [details] Patch
WebKit Review Bot
Comment 2 2011-03-11 01:10:31 PST
Attachment 85443 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8132182
Pavel Feldman
Comment 3 2011-03-11 01:18:57 PST
Comment on attachment 85443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85443&action=review > Source/WebCore/bindings/js/JSInjectedScriptManager.cpp:2 > + * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. I think this is all Google-originating code.
Build Bot
Comment 4 2011-03-11 01:24:41 PST
Attachment 85443 [details] did not build on win: Build output: http://queues.webkit.org/results/8133212
Yury Semikhatsky
Comment 5 2011-03-11 02:38:37 PST
Committed r80837: <http://trac.webkit.org/changeset/80837>
WebKit Review Bot
Comment 6 2011-03-11 02:51:11 PST
http://trac.webkit.org/changeset/80837 might have broken Qt Linux Release minimal, Qt Windows 32-bit Release, and Chromium Linux Release
Yury Semikhatsky
Comment 7 2011-03-11 05:07:19 PST
Reopening since the change was rolled out in r80839.
Yury Semikhatsky
Comment 8 2011-03-11 05:14:57 PST
Created attachment 85461 [details] Patch for landing
Yury Semikhatsky
Comment 9 2011-03-11 05:27:47 PST
Committed r80844: <http://trac.webkit.org/changeset/80844>
Note You need to log in before you can comment on or make changes to this bug.