Bug 56171

Summary:

Fix textarea maxlength bug that return key is not considered.

Product:

WebKit

Reporter:

Naoki Takano <honten>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	ap: review-

Naoki Takano

Reported 2011-03-10 21:31:57 PST

Fix textarea maxlength bug that return key is not considered.

Attachments
Patch (3.00 KB, patch) 2011-03-11 23:38 PST, Naoki Takano	ap: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2011-03-11 12:00:00 PST

*** This bug has been marked as a duplicate of bug 54443 ***

Naoki Takano

Comment 2 2011-03-11 23:38:16 PST

Created attachment 85574 [details] Patch

Naoki Takano

Comment 3 2011-03-11 23:39:27 PST

Could you review?

Alexey Proskuryakov

Comment 4 2011-03-11 23:52:00 PST

Comment on attachment 85574 [details] Patch It should be possible to make an automated test for this. Manual tests are nearly useless. Please attach patches to bug 54443, not here.

Naoki Takano

Comment 5 2011-03-12 00:03:47 PST

I try to make automate test. But I'm not sure I can simulate key pressing in layout test.

Alexey Proskuryakov

Comment 6 2011-03-12 00:50:36 PST

You can look what existing tests for maxlength do for an example. See e.g. fast/forms/script-tests/textarea-maxlength.js, or other tests with "maxlength" in file name.

Note You need to log in before you can comment on or make changes to this bug.