Bug 56158

Summary: support encoding /decoding WebData in usermessages
Product: WebKit Reporter: Alice Liu <alice.barraclough>
Component: WebKit APIAssignee: Alice Liu <alice.barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch sam: review+

Description Alice Liu 2011-03-10 17:51:48 PST 
UserMessage[De|En]coder::base[De|En]code are missing cases for APIObject::TypeData.  This results in WKData not being able to be sent across ipc messages.
Comment 1 Alice Liu 2011-03-10 19:37:14 PST 
Created attachment 85425 [details]
patch
Comment 2 Sam Weinig 2011-03-10 21:34:53 PST 
Comment on attachment 85425 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85425&action=review

> Source/WebKit2/Shared/UserMessageCoders.h:305
> +            coder.m_root = WebData::create(buffer);
> +            break;
> +        }

I think this should return true, hm, we are inconsistent here. I should fix that, the break is fine I guess.
Comment 3 Alice Liu 2011-03-11 19:35:52 PST 
http://trac.webkit.org/changeset/80921