Bug 56135

Summary:

VisiblePosition's next and previous should take an enum instead of a boolean

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

darin, eric, leviw, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
cleanup	tony: review+

Description Ryosuke Niwa 2011-03-10 12:50:49 PST

There many places where we call next(true) and previous(true) and it's totally unclear what it means.

Comment 1 Ryosuke Niwa 2011-03-10 13:08:47 PST

Created attachment 85381 [details]
cleanup

Comment 2 Ryosuke Niwa 2011-03-10 13:16:02 PST

Committed r80752: <http://trac.webkit.org/changeset/80752>

Comment 3 Ryosuke Niwa 2011-03-10 14:46:58 PST

I accidentally reversed the boolean logic in the original patch.  Fixed it in http://trac.webkit.org/changeset/80766.