Bug 56127

Summary: Fix allocation of native function with a cached thunk
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2011-03-10 11:38:53 PST
Fix allocation of native function with a cached thunk
Attachments
Patch (6.45 KB, patch)
2011-03-10 11:40 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-03-10 11:40:14 PST
Created attachment 85355 [details] Patch
Gavin Barraclough
Comment 2 2011-03-10 12:31:56 PST
Fixed in r80743
Oliver Hunt
Comment 3 2011-03-10 12:36:27 PST
Errr wrong bug mate :)
Oliver Hunt
Comment 4 2011-03-10 13:17:08 PST
Committed r80751: <http://trac.webkit.org/changeset/80751>
Gavin Barraclough
Comment 5 2011-03-10 14:02:48 PST
Oooops!
Sergio Villar Senin
Comment 6 2011-03-11 03:02:35 PST
I think this commit maybe the source of some JSC crashes in GTK 32bit Release bot we have been observing recently. In particular these two tests are failing consistently since then: fast/profiler/dead-time.html fast/profiler/stop-profiling-after-setTimeout.html
Sergio Villar Senin
Comment 7 2011-03-11 04:08:55 PST
(In reply to comment #6) > I think this commit maybe the source of some JSC crashes in GTK 32bit Release bot we have been observing recently. In particular these two tests are failing consistently since then: > > fast/profiler/dead-time.html > fast/profiler/stop-profiling-after-setTimeout.html Looks like I was wrong, after reverting 80742 and 80743 no crash at all. Sorry for the noise.
Note You need to log in before you can comment on or make changes to this bug.