Bug 56122

Summary:

Remove unnecessary function WebPlugin::getBackingTextureId

Product:

WebKit

Reporter:

Alok Priyadarshi <alokp>

Component:

Plug-ins

Assignee:

Alok Priyadarshi <alokp>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, jamesr, piman, vangelis

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	none

Description Alok Priyadarshi 2011-03-10 10:40:03 PST

WebPlugin::getBackingTextureId is not required anymore. We use WebPluginContainer::setBackingTextureId now.

Comment 1 Alok Priyadarshi 2011-03-10 10:47:40 PST

Created attachment 85349 [details]
proposed patch

Comment 2 Antoine Labour 2011-03-10 10:55:20 PST

LGTM FWIW

Comment 3 Alok Priyadarshi 2011-03-14 13:50:41 PDT

ping!

Comment 4 Alok Priyadarshi 2011-03-15 09:00:43 PDT

Hi James: Please review.

Comment 5 James Robinson 2011-03-15 09:48:46 PDT

Comment on attachment 85349 [details]
proposed patch

FYI getters in WebKit should not have a "get"prefix (it should be "textureId()", not getTextureId().

Comment 6 WebKit Commit Bot 2011-03-15 10:14:38 PDT

Comment on attachment 85349 [details]
proposed patch

Clearing flags on attachment: 85349

Committed r81143: <http://trac.webkit.org/changeset/81143>

Comment 7 WebKit Commit Bot 2011-03-15 10:14:42 PDT

All reviewed patches have been landed.  Closing bug.