Bug 56122

Summary: Remove unnecessary function WebPlugin::getBackingTextureId
Product: WebKit Reporter: Alok Priyadarshi <alokp>
Component: Plug-insAssignee: Alok Priyadarshi <alokp>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, jamesr, piman, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Alok Priyadarshi
Reported 2011-03-10 10:40:03 PST
WebPlugin::getBackingTextureId is not required anymore. We use WebPluginContainer::setBackingTextureId now.
Attachments
proposed patch (2.30 KB, patch)
2011-03-10 10:47 PST, Alok Priyadarshi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alok Priyadarshi
Comment 1 2011-03-10 10:47:40 PST
Created attachment 85349 [details] proposed patch
Antoine Labour
Comment 2 2011-03-10 10:55:20 PST
LGTM FWIW
Alok Priyadarshi
Comment 3 2011-03-14 13:50:41 PDT
ping!
Alok Priyadarshi
Comment 4 2011-03-15 09:00:43 PDT
Hi James: Please review.
James Robinson
Comment 5 2011-03-15 09:48:46 PDT
Comment on attachment 85349 [details] proposed patch FYI getters in WebKit should not have a "get"prefix (it should be "textureId()", not getTextureId().
WebKit Commit Bot
Comment 6 2011-03-15 10:14:38 PDT
Comment on attachment 85349 [details] proposed patch Clearing flags on attachment: 85349 Committed r81143: <http://trac.webkit.org/changeset/81143>
WebKit Commit Bot
Comment 7 2011-03-15 10:14:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.