Bug 56090

Summary: Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://build.webkit.org/LeaksViewer/?url=http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80699%20(15461)/DumpRenderTree-leaks.txt
Bug Depends on:    
Bug Blocks: 56035    
Attachments:
Description Flags
Patch aroben: review+

Adam Roben (:aroben)
Reported 2011-03-10 04:14:10 PST
To reproduce: 1. Go to http://build.webkit.org/LeaksViewer/?url=http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80699%20(15461)/DumpRenderTree-leaks.txt The leaks output never shows up. The Inspector shows that a "TypeError: Cannot post cyclic structures" exception was thrown.
Attachments
Patch (14.62 KB, patch)
2011-04-25 16:37 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-10 04:15:43 PST
In addition, Leaks Viewer says it's "loading" forever. That's bug 56091.
Adam Roben (:aroben)
Comment 2 2011-03-10 06:06:41 PST
Oh, the error doesn't happen in ToT, only in Safari 5.
Adam Roben (:aroben)
Comment 3 2011-03-10 08:15:49 PST
I'm surprised this doesn't happen for all leaks files.
Adam Roben (:aroben)
Comment 4 2011-03-10 08:19:46 PST
Maybe we just shouldn't use Web Workers in Safari 5.
Adam Roben (:aroben)
Comment 5 2011-03-10 08:22:20 PST
I think the only way to test whether cyclic structures can be sent in postMessage is to try doing it and see if an exception is thrown.
Adam Roben (:aroben)
Comment 6 2011-03-10 08:35:54 PST
…I guess it does happen on any leaks file.
Sam Weinig
Comment 7 2011-04-25 16:37:09 PDT
Created attachment 91012 [details] Patch
Sam Weinig
Comment 8 2011-04-25 16:42:08 PDT
Committed r84840: <http://trac.webkit.org/changeset/84840>
Note You need to log in before you can comment on or make changes to this bug.