Summary: | [GTK] run-gtk-tests doesn't fail if a test crashes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, gustavo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Philippe Normand
2011-03-10 04:12:42 PST
Created attachment 85307 [details]
proposed patch
Comment on attachment 85307 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=85307&action=review > Tools/Scripts/run-gtk-tests:41 > + if (!$exitStatus && $?) { > + $exitStatus = $?; No need to check whether exitstatus is already set, I think, just check that $? is non-zero and assign unconditionally. Committed r80712: <http://trac.webkit.org/changeset/80712> http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug (In reply to comment #4) > http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug It was broken already before, this patch just unveiled previously undetected redness. |