Bug 56089

Summary: [GTK] run-gtk-tests doesn't fail if a test crashes
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gustavo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch gustavo: review+

Philippe Normand
Reported 2011-03-10 04:12:42 PST
One test crashing for a week and a green "unittests" box in the waterfall... See also https://bugs.webkit.org/show_bug.cgi?id=56083
Attachments
proposed patch (1.60 KB, patch)
2011-03-10 04:18 PST, Philippe Normand 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-03-10 04:18:58 PST
Created attachment 85307 [details] proposed patch
Gustavo Noronha (kov)
Comment 2 2011-03-10 05:50:44 PST
Comment on attachment 85307 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=85307&action=review > Tools/Scripts/run-gtk-tests:41 > + if (!$exitStatus && $?) { > + $exitStatus = $?; No need to check whether exitstatus is already set, I think, just check that $? is non-zero and assign unconditionally.
Philippe Normand
Comment 3 2011-03-10 06:14:21 PST
Committed r80712: <http://trac.webkit.org/changeset/80712>
WebKit Review Bot
Comment 4 2011-03-10 07:07:51 PST
http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug
Philippe Normand
Comment 5 2011-03-10 07:12:57 PST
(In reply to comment #4) > http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug It was broken already before, this patch just unveiled previously undetected redness.
Note You need to log in before you can comment on or make changes to this bug.