Summary: | Reproducible ASSERTION failure going to NYTimes.com | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> |
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | aestes, alice.barraclough, ap, darin, jberlin, yong.li.webkit |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All |
Description
Jessie Berlin
2011-03-09 17:30:23 PST
The assertion that is failing is ASSERT(m_suspended). *** Bug 56073 has been marked as a duplicate of this bug. *** Comment from https://bugs.webkit.org/show_bug.cgi?id=55941: Comment #6 From Pavel Feldman 2011-03-10 07:19:04 PST (-) [reply] Rolled out r80478 as r80718 Committing to http://svn.webkit.org/repository/webkit/trunk ... D Source/WebCore/manual-tests/database-callback-deferred.html M LayoutTests/ChangeLog M LayoutTests/platform/gtk/Skipped M Source/WebCore/ChangeLog M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/PageGroupLoadDeferrer.cpp Committed r80718 This seems like a conflict between WKBundlePageSetDefersLoading and PageGroupLoadDeferrer, and should be fixed there but not by rolling out r80478 which does fix missing callback problme. Should we reopen this one? Never mind. I see why r80478 causes the crash now: Without the patch Page::setDefersLoading doesn't do this: for (Frame* frame = otherPage->mainFrame(); frame; frame = frame->tree()->traverseNext()) { frame->document()->suspendScriptedAnimationControllerCallbacks(); frame->document()->suspendActiveDOMObjects(ActiveDOMObject::WillShowDialog); frame->document()->scriptRunner()->suspend(); if (DocumentParser* parser = frame->document()->parser()) parser->suspendScheduledTasks(); } So I'll remove this change from my patch |