Bug 56053 – Deleting content directly following a button inserts an unnecessary placeholder

• Component: HTML Editing
• Status: RESOLVED FIXED

[Levi Weintraub]

See attachment.

Deleting any content directly following a button adds a br "placeholder" to the DOM, which is unexpected. Simply place the caret after the space following the button and hit backspace to repro.

[Levi Weintraub]

Created attachment 85253 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 85253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review

looks sane to me.

> LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9
> +target = document.getElementById("container");

Nit: Missing "var".

> LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11
> +window.getSelection().modify("move", "Right", "character");

Nit: Capitalize / de-capitalize all words here (make them consistent).

[Levi Weintraub]

(In reply to comment #2)
> (From update of attachment 85253 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review
> 
> looks sane to me.
> 
> > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9
> > +target = document.getElementById("container");
> 
> Nit: Missing "var".
> 
> > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11
> > +window.getSelection().modify("move", "Right", "character");
> 
> Nit: Capitalize / de-capitalize all words here (make them consistent).

Thanks for the review! I'll fix those and land :)

[Levi Weintraub]

Committed r81056: <http://trac.webkit.org/changeset/81056>