Bug 56048

Summary: Clean up some gross code in chromium/TestShellWin.cpp
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: Tools / TestsAssignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch v1
none
patch v2 none

Peter Kasting
Reported 2011-03-09 13:29:33 PST
The Windows version check stuff in TestShellWin.cpp is horrid. Patch momentarily.
Attachments
patch v1 (4.28 KB, patch)
2011-03-09 13:31 PST, Peter Kasting 		no flags
DetailsFormatted DiffDiff
patch v2 (4.24 KB, patch)
2011-03-09 14:19 PST, Peter Kasting 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2011-03-09 13:31:49 PST
Created attachment 85223 [details] patch v1
Peter Kasting
Comment 2 2011-03-09 14:19:11 PST
Created attachment 85232 [details] patch v2 Switch to using OSVERSIONINFO because it's slightly cleaner.
Dimitri Glazkov (Google)
Comment 3 2011-03-09 14:51:46 PST
Comment on attachment 85232 [details] patch v2 k
WebKit Commit Bot
Comment 4 2011-03-10 19:36:57 PST
Comment on attachment 85232 [details] patch v2 Rejecting attachment 85232 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2 Last 500 characters of output: Source/WebCore/page/Page.cpp M Source/WebCore/page/FrameView.h M Source/WebCore/platform/ScrollView.cpp M Source/WebCore/platform/ScrollView.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderDataGrid.cpp r80804 = 0bcced00a0585c5936e8c2aee745dcf8dd87c118 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8135143
WebKit Commit Bot
Comment 5 2011-03-10 22:45:38 PST
Comment on attachment 85232 [details] patch v2 Clearing flags on attachment: 85232 Committed r80817: <http://trac.webkit.org/changeset/80817>
WebKit Commit Bot
Comment 6 2011-03-10 22:45:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.