Bug 56032

Summary: Leaks viewer should be linked from leaks bot results page
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 56028    
Bug Blocks:    
Attachments:
Description Flags
Add a "view leaks" link to builds on SnowLeopard Intel Leaks
ddkilzer: review+
Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
none
Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished() sullivan: review+

David Kilzer (:ddkilzer)
Reported 2011-03-09 11:10:38 PST
The leaks viewer should be linked directly from the leaks bot results page.
Attachments
Add a "view leaks" link to builds on SnowLeopard Intel Leaks (4.67 KB, patch)
2011-04-06 14:36 PDT, Adam Roben (:aroben)
ddkilzer: review+
Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete() (3.54 KB, patch)
2011-04-07 06:28 PDT, Adam Roben (:aroben)
no flags
Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished() (2.99 KB, patch)
2011-04-07 07:13 PDT, Adam Roben (:aroben)
sullivan: review+
Adam Roben (:aroben)
Comment 1 2011-04-06 14:36:50 PDT
Created attachment 88515 [details] Add a "view leaks" link to builds on SnowLeopard Intel Leaks
David Kilzer (:ddkilzer)
Comment 2 2011-04-06 14:41:00 PDT
Comment on attachment 88515 [details] Add a "view leaks" link to builds on SnowLeopard Intel Leaks r=me!
Adam Roben (:aroben)
Comment 3 2011-04-06 14:58:13 PDT
Adam Roben (:aroben)
Comment 4 2011-04-06 15:48:52 PDT
Adam Roben (:aroben)
Comment 5 2011-04-06 16:06:48 PDT
Maybe we need to call self.addURL before calling MasterShellCommand.finished. Maybe we should move the addURL calls to createSummary, like in the examples on <http://buildbot.net/buildbot/docs/current/BuildStep-URLs.html#BuildStep-URLs>?
Adam Roben (:aroben)
Comment 6 2011-04-07 06:28:27 PDT
Created attachment 88617 [details] Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
Adam Roben (:aroben)
Comment 7 2011-04-07 06:47:31 PDT
Adam Roben (:aroben)
Comment 8 2011-04-07 07:13:32 PDT
Adam Roben (:aroben)
Comment 9 2011-04-07 07:13:52 PDT
Created attachment 88628 [details] Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
Adam Roben (:aroben)
Comment 10 2011-04-07 07:17:24 PDT
Adam Roben (:aroben)
Comment 11 2011-04-07 09:10:52 PDT
Note You need to log in before you can comment on or make changes to this bug.