| Summary: | Leaks viewer should be linked from leaks bot results page | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aroben | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 56028 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
David Kilzer (:ddkilzer)
2011-03-09 11:10:38 PST
Created attachment 88515 [details]
Add a "view leaks" link to builds on SnowLeopard Intel Leaks
Comment on attachment 88515 [details]
Add a "view leaks" link to builds on SnowLeopard Intel Leaks
r=me!
Committed r83101: <http://trac.webkit.org/changeset/83101> This seems not to have worked: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/16078 Maybe we need to call self.addURL before calling MasterShellCommand.finished. Maybe we should move the addURL calls to createSummary, like in the examples on <http://buildbot.net/buildbot/docs/current/BuildStep-URLs.html#BuildStep-URLs>? Created attachment 88617 [details]
Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
Committed r83168: <http://trac.webkit.org/changeset/83168> Another failure: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/10463 Now the "view results" URL is gone, too! :-( Created attachment 88628 [details]
Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
Committed r83170: <http://trac.webkit.org/changeset/83170> Seems to be working now: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/16096 |