Bug 56015

Summary: Web Inspector: Highlighter refactoring
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Andrey Adaikin 2011-03-09 07:21:55 PST 
Highlighter refactoring to get rid of the current highlighter state (this._lastHighlightedLine & this._lastHighlightedColumn).

Also I found a bug in the old highlighter in the updateHighlight() method, added a test that fails the old implementation.
Comment 1 Andrey Adaikin 2011-03-09 07:27:11 PST 
Created attachment 85173 [details]
Patch
Comment 2 Andrey Adaikin 2011-03-09 09:20:46 PST 
Created attachment 85183 [details]
Patch
Comment 3 Pavel Podivilov 2011-03-10 04:11:12 PST 
Comment on attachment 85183 [details]
Patch

Clearing flags on attachment: 85183

Committed r80704: <http://trac.webkit.org/changeset/80704>
Comment 4 Pavel Podivilov 2011-03-10 04:11:25 PST 
All reviewed patches have been landed.  Closing bug.