Bug 56015

Summary: Web Inspector: Highlighter refactoring
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Andrey Adaikin
Reported 2011-03-09 07:21:55 PST
Highlighter refactoring to get rid of the current highlighter state (this._lastHighlightedLine & this._lastHighlightedColumn). Also I found a bug in the old highlighter in the updateHighlight() method, added a test that fails the old implementation.
Attachments
Patch (23.95 KB, patch)
2011-03-09 07:27 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (24.31 KB, patch)
2011-03-09 09:20 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2011-03-09 07:27:11 PST
Created attachment 85173 [details] Patch
Andrey Adaikin
Comment 2 2011-03-09 09:20:46 PST
Created attachment 85183 [details] Patch
Pavel Podivilov
Comment 3 2011-03-10 04:11:12 PST
Comment on attachment 85183 [details] Patch Clearing flags on attachment: 85183 Committed r80704: <http://trac.webkit.org/changeset/80704>
Pavel Podivilov
Comment 4 2011-03-10 04:11:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.